Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Catch "No tests found" during CI" #2390

Merged
merged 4 commits into from
May 27, 2017
Merged

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented May 27, 2017

Reverts #2387

It seems like actually fixing the issue causes a test failure with a weird message.
Let's just remove this for now.

@gaearon gaearon merged commit 3f34238 into master May 27, 2017
zangrafx added a commit to zangrafx/create-react-app that referenced this pull request May 31, 2017
* master:
  Add WebStorm >2017 launchEditor Support (facebook#2414)
  docs: update `jest-enzyme` section (facebook#2392)
  Fix detection of parent directory in ModuleScopePlugin (facebook#2405)
  Added cache clear to e2e scripts (facebook#2400)
  Fix kill command in e2e-kitchensink.sh cleanup (facebook#2397)
  Revert "Catch "No tests found" during CI" (facebook#2390)
  Fix wrong path expansion in end-to-end test (facebook#2388)
  Suggest just "yarn build" (facebook#2385)
  Catch "No tests found" during CI (facebook#2387)
  Publish
  Add changelog for 1.0.7 (facebook#2384)
  Update webpack to 2.6.1 (facebook#2383)
  Consistently set environment variables (facebook#2382)
  Disable comparisons feature in uglify compression in production (facebook#2379)
  Removed the overriding of reduce_vars to false since webpack v2.6.0 included the fixed for Uglify bug (facebook#2351)
romaindso pushed a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017
* Revert "Fix wrong path expansion in end-to-end test (facebook#2388)"

This reverts commit 2aafaad.

* Revert "Suggest just "yarn build" (facebook#2385)"

This reverts commit 70bf125.

* Revert "Catch "No tests found" during CI (facebook#2387)"

This reverts commit 5317b3f.
wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017
* Revert "Fix wrong path expansion in end-to-end test (#2388)"

This reverts commit 2aafaad.

* Revert "Suggest just "yarn build" (#2385)"

This reverts commit 70bf125.

* Revert "Catch "No tests found" during CI (#2387)"

This reverts commit 5317b3f.
@Timer Timer deleted the revert-2387-catch-no-tests branch October 31, 2017 00:29
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants